8000 [3.0] Remove more deprecated interfaces in Form and Validator by nicolas-grekas · Pull Request #16067 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is done, then not only in master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let @nicolas-grekas submit a PR for this on 2.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16084

@Tobion
Copy link
Contributor
Tobion commented Oct 2, 2015

👍 apart from the above comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must also remove support for when a Request is passed, I don't see where it's done here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is/was a listener that transforms the data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the investigation

@fabpot
Copy link
Member
fabpot commented Oct 2, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit a743fb6 into symfony:master Oct 2, 2015
fabpot added a commit that referenced this pull request Oct 2, 2015
…lidator (nicolas-grekas)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] Remove more deprecated interfaces in Form and Validator

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a743fb6 [3.0] Remove more deprecated interfaces in Form and Validator
@nicolas-grekas nicolas-grekas deleted the master-clean branch October 2, 2015 11:29
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0