8000 [HttpFoundation] removed the ParameterBag::get() deep argument by fabpot · Pull Request #16019 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] removed the ParameterBag::get() deep argument #16019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2015
Merged

[HttpFoundation] removed the ParameterBag::get() deep argument #16019

merged 1 commit into from
Oct 1, 2015

Conversation

@fabpot
Copy link
Member
@fabpot fabpot commented Sep 30, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@Tobion
Copy link
Contributor
Tobion commented Sep 30, 2015

Tests are failing

@xabbuh
Copy link
Member
xabbuh commented Sep 30, 2015

Status: Needs work

@fabpot fabpot force-pushed the deep-get-deprecated-removal branch from 9687444 to 317f7b4 Compare September 30, 2015 20:36
@fabpot
Copy link
Member Author
fabpot commented Sep 30, 2015

Fixed

@xabbuh
Copy link
Member
xabbuh commented Sep 30, 2015

The tests with Symfony 2.8 still as the number of arguments of the get() method has changed.

@fabpot
Copy link
Member Author
fabpot commented Oct 1, 2015

#16037 will fix that.

@fabpot fabpot merged commit 317f7b4 into symfony:master Oct 1, 2015
fabpot added a commit that referenced this pull request Oct 83A5 1, 2015
@fabpot
feature #16019 [HttpFoundation] removed the ParameterBag::get() deep …
763d478 
…argument (fabpot)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[HttpFoundation] removed the ParameterBag::get() deep argument

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

317f7b4 [HttpFoundation] removed the ParameterBag::get() deep argument
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabpot @Tobion @xabbuh @carsonbot
0