8000 Updated the styles of the Twig commands by javiereguiluz · Pull Request #15989 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Updated the styles of the Twig commands #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Updated the styles of the Twig commands #15989

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

twig_1

twig_2

twig_3

twig_4

@javiereguiluz javiereguiluz mentioned this pull request Sep 29, 2015
Closed
60 tasks
Tobion
Tobion reviewed Sep 29, 2015
View reviewed changes
src/Symfony/Bridge/Twig/Command/LintCommand.php
@@ -157,32 +161,36 @@ private function validate(\Twig_Environment $twig, $template, $file)
return array('template' => $template, 'file' => $file, 'valid' => true);
}

private function display(InputInterface $input, OutputInterface $output, $files)
private function display(InputInterface $input, OutputInterface $stdout, $output, $files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing typehint for style

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather keep $output for the object received as $output in arguments and used a different name for the styling wrapper. It would be more readable IMO

@fabpot
Copy link
Member
fabpot commented Oct 1, 2015

Can you rebase as tests were badly broken where run? Thanks.

@javiereguiluz
Copy link
Member Author

Rebased.

@fabpot
Copy link
Member
fabpot commented Oct 1, 2015

Thank you @javiereguiluz.

@fabpot fabpot closed this in 1309cfb Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@javiereguiluz @fabpot @stof @Tobion @ogizanagi @carsonbot
0