8000 Remove profiler storages by javiereguiluz · Pull Request #15944 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove profiler storages #15944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Remove profiler storages #15944

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
14bde56
Deprecated all profiler storages except FileProfilerStorage
javiereguiluz Sep 27, 2015
8bc599c
Added the UPGRADE note
javiereguiluz Sep 27, 2015
5739807
Use FileStorage instead of SQLiteStorage for the ProfilerTest
javiereguiluz Sep 27, 2015
55a5fcf
Added the @deprecated notices in PHPdoc
javiereguiluz Sep 27, 2015
19cf251
Added @group legacy for deprecated tests
javiereguiluz Sep 27, 2015
89eef1e
Added deprecation notices for profiler "dsn", "username" and "passwor…
javiereguiluz Sep 27, 2015
f37d191
Fixed syntax issues
javiereguiluz Sep 27, 2015
70aa3da
Fixed a minor syntax issue
javiereguiluz Sep 29, 2015
b8a8a7c
Refactored the config tree
javiereguiluz Sep 29, 2015
94f5e98
Moved deprecation notices at the begining of the classes
javiereguiluz Sep 30, 2015
994ab2c
Reverted the changes on the profiler test
javiereguiluz Sep 30, 2015
acb416d
Trigger error notices instead of throwing exceptions
javiereguiluz Sep 30, 2015
213d5a8
Improve the condition to trigger the error
javiereguiluz Sep 30, 2015
4242bfa
Display deprecation errors in child classes too
javiereguiluz Sep 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed syntax issues
  • Loading branch information
@javiereguiluz
javiereguiluz committed Sep 30, 2015
commit f37d191bf669d46b2577359d4432ee2a9b4b9a37
3 changes: 3 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,16 +268,19 @@ private function addProfilerSection(ArrayNodeDefinition $rootNode)
->ifTrue(function ($v) { return 'file:' !== substr($v['dsn'], 0, 5); })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to check whether the dsn key exists before accessing it, as you run it on unvalidated configuration.
The alternative is to put this trigger on the dsn node itself rather than on the profiler node, as it deals with a single value anyway

->then(function ($v) {
@trigger_error('The profiler.dsn configuration key must start with "file:" because all the storages except the filesystem are deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);

return $v;
})
->ifTrue(function ($v) { return array_key_exists('username', $v); })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot call ifTrue multiple times in the same ->beforeNormalization (it would replace the previous condition).
You need multiple beforeNormalization here.

->then(function ($v) {
@trigger_error('The profiler.username configuration key is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that you need to trigger it all the time when username is configured, and you don't need to access the other fields, it would be better to put this beforeNormalization directly on the username node (and then, you can use ->always() for the condition as the processing will only normalize the value if it is configured)


return $v;
})
->ifTrue(function ($v) { return array_key_exists('password', $v); })
->then(function ($v) {
@trigger_error('The profiler.password configuration key is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);

return $v;
})
->end()
Expand Down
0