Fix URL validator failure with empty string #15898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd9b195 to
396a366
Compare
|
this needs a test to prevent regressions |
|
Closing in favor of #16152 where I added a test |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
…rsky-bw) This PR was merged into the 2.3 branch. Discussion ---------- Fix URL validator failure with empty string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15898 | License | MIT | Doc PR | ~ Fix validator failure if method `__toString` of passed object return an empty string. Commits ------- e0910d9 Fix URL validator failure with empty string 0f61859 [Validator] added a failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validator failure if method
__toStringof passed object return an empty string.