8000 Avoid errors when generating the logout URL when there is no firewall key by javiereguiluz · Pull Request #15861 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Avoid errors when generating the logout URL when there is no firewall key #15861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Avoid errors when generating the logout URL when there is no firewall key #15861

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #15853
License MIT
Doc PR -

@javiereguiluz javiereguiluz mentioned this pull request Sep 21, 2015
Closed
Tobion
Tobion reviewed Sep 21, 2015
View reviewed changes
src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php
@@ -34,10 +36,11 @@ class SecurityDataCollector extends DataCollector
* @param TokenStorageInterface|null $tokenStorage
* @param RoleHierarchyInterface|null $roleHierarchy
*/
public function __construct(TokenStorageInterface $tokenStorage = null, RoleHierarchyInterface $roleHierarchy = null)
public function __construct(TokenStorageInterface $tokenStorage = null, RoleHierarchyInterface $roleHierarchy = null, LogoutUrlGenerator $logoutUrlGenerator = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpdoc missing

@weaverryan
Copy link
Member

Adding the optional constructor arg is consistent with our BC policy, but should be minimized. But since this is a data collector, it seems safe to me. As does swallowing the \Exception, which would normally be a problem.

Unless someone has an issue with the added constructor arg, 👍

Status: Reviewed

@fabpot
Copy link
Member
fabpot commented Sep 23, 2015

Thank you @javiereguiluz.

@fabpot fabpot closed this Sep 23, 2015
fabpot added a commit that referenced this pull request Sep 23, 2015
@fabpot
bug #15861 Avoid errors when generating the logout URL when there is …
d1ae400 
…no firewall key (javiereguiluz)

This PR was squashed before being merged into the 2.8 branch (closes #15861).

Discussion
----------

Avoid errors when generating the logout URL when there is no firewall key

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15853
| License       | MIT
| Doc PR        | -

Commits
-------

a811912 Avoid errors when generating the logout URL when there is no firewall key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @weaverryan @fabpot @Tobion @carsonbot
0