[Form] fixed something: Remove whitespaces between <input> and <label> #15836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: With the whitespaces, there would be a "gap" between <input> and <label> which is clickable, but doesn't activate the <input>. It's easy to *add* some margin with CSS, whereas it's impossible to *remove* whitespaces with CSS.
|
@ThomasLandauer so I assume you render the form manually with the label after the input? Otherwise the whitespace would be before the label and not between label and input. Looks good. 👍 |
|
No, in my case it is about radio buttons (type 'choice'). As far as I understand, the label rendering mechanism is the same as for text-input's. |
|
I see |
|
Thank you @ThomasLandauer. |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2015
…t> and <label> (ThomasLandauer) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #15836). Discussion ---------- [Form] fixed something: Remove whitespaces between <input> and <label> | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [no] | BC breaks? | [?] What means BC? | Deprecations? | [no] | Tests pass? | [yes] | Fixed tickets | [] | License | MIT | Doc PR | [] Reason: With the whitespaces, there would be a "gap" between `<input>` and `<label>` which is clickable, but doesn't activate the `<input>`. It's easy to *add* some margin with CSS, whereas it's impossible to *remove* whitespaces with CSS. Commits ------- 1b97c17 Remove whitespaces between <input> and <label>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: With the whitespaces, there would be a "gap" between
<input>and<label>which is clickable, but doesn't activate the<input>.It's easy to add some margin with CSS, whereas it's impossible to remove whitespaces with CSS.