8000 [HttpFoundation] NativeSessionStorage `regenerate` method wrongly sets storage as started by iambrosi · Pull Request #15799 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] NativeSessionStorage regenerate method wrongly sets storage as started #15799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[HttpFoundation] NativeSessionStorage regenerate method wrongly sets storage as started #15799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12828e7
Test `regenerate` wrongly sets storage as started
iambrosi Sep 14, 2015
a269a91
Don't regenerate the id of non-active sessions
iambrosi Sep 14, 2015
a492a7a
Fix check for active sessions in PHP >= 5.4
iambrosi Sep 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Test regenerate wrongly sets storage as started 
The Session Storage should not be flagged as started if
`session_regenerate_id` fails. A common use case would be to attempt
regeneration before actually starting the session.
  • Loading branch information
@iambrosi
iambrosi committed Sep 14, 2015
commit 12828e7665e89b400c3f0a564b8ad4c0c0a344c7
7 changes: 7 additions & 0 deletions src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ public function testSessionGlobalIsUpToDateAfterIdRegeneration()
$this->assertEquals(42, $_SESSION['_sf2_attributes']['lucky']);
}

public function testRegenerationFailureDoesNotFlagStorageAsStarted()
{
$storage = $this->getStorage();
$this->assertFalse($storage->regenerate());
$this->assertFalse($storage->isStarted());
}

public function testDefaultSessionCacheLimiter()
{
$this->iniSet('session.cache_limiter', 'nocache');
Expand Down
0