[Console] Default to stderr for the console helpers (2.7+) #15795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +94,10 @@ public function run(OutputInterface $output, $cmd, $error = null, $callback = nu | |||
| */ | |||
| public function mustRun(OutputInterface $output, $cmd, $error = null, $callback = null) | |||
| { | |||
| if ($output instanceof ConsoleOutputInterface) { | |||
| $output = $output->getErrorOutput(); | |||
There was a problem hiding this comment.
this is useless as it is covered by run()
There was a problem hiding this comment.
You are correct. Let me adjust that quickly.
|
👍 Status: Reviewed |
|
Thank you @alcohol. |
fabpot
added a commit
that referenced
this pull request
Sep 22, 2015
… (alcohol) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Default to stderr for the console helpers (2.7+) Interactive input/output and informational output such as progress should go to `stderr` if available. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Only merge if #15794 is merged. If someone explicitly wants to use `stdout`, they can simply pass `$output->getStream()` instead of `$output` in most use-cases. Commits ------- 90c2a96 Default to stderr for console helpers (only merge if #15794 gets merged)
Whats the reasoning for this? Broke a lot of bash scripts with progress bars... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactive input/output and informational output such as progress should go to
stderrif available.Only merge if #15794 is merged.
If someone explicitly wants to use
stdout, they can simply pass$output->getStream()instead of$outputin most use-cases.