8000 Fix the injection of the container in invokable controllers by stof · Pull Request #15737 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix the injection of the container in invokable controllers #15737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2015
Merged

Fix the injection of the container in invokable controllers #15737

merged 1 commit into from
Sep 9, 2015

Conversation

stof
Copy link
Member
@stof stof commented Sep 9, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR n/a

#12022 added the necessary extension point in the ControllerResolver to hook into the instantiation (in 2.6+), but has not updated FrameworkBundle to use it.

I also reused the parent createController method instead of duplicating its code

@stof stof added the Ready label Sep 9, 2015
@jakzal
Copy link
Contributor
jakzal commented Sep 9, 2015

👍

@Tobion
Copy link
Contributor
Tobion commented Sep 9, 2015

👍

Status: Reviewed

@Tobion
Copy link
Contributor
Tobion commented Sep 9, 2015

Thanks @stof.

@Tobion Tobion merged commit 36e09da into symfony:2.7 Sep 9, 2015
Tobion added a commit that referenced this pull request Sep 9, 2015
@Tobion
bug #15737 Fix the injection of the container in invokable controller…
ac822f9 
…s (stof)

This PR was merged into the 2.7 branch.

Discussion
----------

Fix the injection of the container in invokable controllers

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | n/a

#12022 added the necessary extension point in the ControllerResolver to hook into the instantiation (in 2.6+), but has not updated FrameworkBundle to use it.

I also reused the parent ``createController`` method instead of duplicating its code

Commits
-------

36e09da Fix the injection of the container in invokable controllers
@stof stof deleted the fix_callable_container_aware branch September 9, 2015 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @jakzal @Tobion @carsonbot
0