8000 fix class use and in phpdoc by ewgRa · Pull Request #15733 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

fix class use and in phpdoc #15733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix class use and in phpdoc #15733

wants to merge 3 commits into from

Conversation

ewgRa
Copy link
Contributor
@ewgRa ewgRa commented Sep 8, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Just some fixes from code inspection.

@ewgRa ewgRa changed the title WIP fix class use and in phpdoc fix class use and in phpdoc Sep 8, 2015
nicolas-grekas
nicolas-grekas reviewed Sep 9, 2015
View reviewed changes
src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/DoctrineExtensionTest.php
@@ -49,7 +49,7 @@ protected function setUp()
}

/**
* @expectedException LogicException
* @expectedException \LogicException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectedException always take a fqcn, which means there is no need for a starting \ for these annotations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but phpstorm can't understand this and show that this class is undefined. This is only phpstorm problem? In other IDE it works well with "Find usage" functionality for example, or when you click on this class to check its source?

@nicolas-grekas
Copy link
Member

👍 squashed+rebased on 2.7 (no need to update the PR we can do it when merging @ewgRa)

@Tobion
Copy link
Contributor
Tobion commented Sep 9, 2015

👍

@Tobion
Copy link
Contributor
Tobion commented Sep 9, 2015

Thank you @ewgRa.

@Tobion Tobion closed this in 7c3748c Sep 9, 2015
Tobion added a commit that referenced this pull request Sep 9, 2015
@Tobion
2.8 changes from #15733
14c538e
@ewgRa ewgRa deleted the class_usage branch September 9, 2015 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewgRa @nicolas-grekas @Tobion @carsonbot
0