-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translator][Loader] added XLIFF 2.0 support. #15717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ff5d6a3
ce540ae
ace6042
7af4fc7
0c24d55
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,7 +164,7 @@ public function testLoadVersion2() | |
$this->assertCount(3, $domains['domain1']); | ||
$this->assertContainsOnly('string', $catalogue->all('domain1')); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
// Notes aren't assigned to specific segments, but to whole units, so there's no way to do a mapping | ||
$this->assertEmpty($catalogue->getMetadata()); | ||
// target attributes | ||
$this->assertEquals(array('target-attributes' => array('order' => 1)), $catalogue->getMetadata('bar', 'domain1')); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support for notes and target attributes should be added for XLiff 2 for the equivalent features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only added support for target attributes
but for notes there's no way to do a mapping because aren't assigned to specific segments, but to whole units.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof what do you think to take account of
notes
only when aunit
contains onesegment
and ignore other cases ?