removed some Form related deprecation notices #15711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
d80dd2e to
fed9cf4
Compare
|
I've fixed some more thanks to Silex. |
|
👍 Status: Reviewed |
|
Some tests are failing though |
|
yeah, tests checking these methods explicitly. they should be updated for the new returned value. and we should probably write integration tests for these classes (using the FormIntegrationTestCase), to run the extension code from a form factory as this is where deprecations are triggered |
fed9cf4 to
4253824
Compare
fabpot
added a commit
that referenced
this pull request
Sep 8, 2015
This PR was merged into the 2.8 branch. Discussion ---------- removed some Form related deprecation notices | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This removes a deprecation notice. Commits ------- 4253824 removed some Form deprecation notices
|
We only enforce version 2.8 or higher of the Form component for tests in the FrameworkBundle. Shouldn't we first check the installed version of the Form component (alternatively we could add a conflict rule, but that doesn't seem to be the best solution to me)? |
|
see #15721 |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2015
…versions (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] compatibility with older Form component versions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15711 | License | MIT | Doc PR | Commits ------- 01ad767 compatibility with older Form component versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a deprecation notice.