8000 [3.0] [Validator] deprecations cleanup by TomasVotruba · Pull Request #15708 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[3.0] [Validator] deprecations cleanup #15708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[3.0] [Validator] deprecations cleanup #15708

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df22026
merge
TomasVotruba Sep 13, 2015
89314c8
[3.0] validator deprecations cleanup
TomasVotruba Sep 7, 2015
fc257bc
[3.0] validator deprecations cleanup [part 2]
TomasVotruba Sep 7, 2015
b5f40a7
[3.0] validator deprecations cleanup - form
TomasVotruba Sep 7, 2015
c2b495b
cs
TomasVotruba Sep 7, 2015
630346a
[3.0] validator deprecations cleanup - form, validation listener
TomasVotruba Sep 7, 2015
b594d26
[3.0] validator deprecations cleanup - cleanup commented code
TomasVotruba Sep 8, 2015
9dcaeb0
return commented code
TomasVotruba Sep 12, 2015
4f1b8c9
[3.0] validator deprecations cleanup - cleanup legacy code
TomasVotruba Sep 12, 2015
c8aabb5
cs fix
TomasVotruba Sep 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
return commented code
  • Loading branch information
@TomasVotruba
TomasVotruba committed Sep 21, 2015
commit 9dcaeb055fa1eb5dd8b2b6638ceeaed528d3bbb3
74 changes: 37 additions & 37 deletions src/Symfony/Component/Form/Tests/Extension/Validator/Type/FormTypeValidatorExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,47 +19,47 @@ class FormTypeValidatorExtensionTest extends BaseValidatorExtensionTest
{
public function testSubmitValidatesData()
{
// $builder = $this->factory->createBuilder(
// 'Symfony\Component\Form\Extension\Core\Type\FormType',
// null,
// array(
// 'validation_groups' => 'group',
// )
// );
// $builder->add('firstName', 'Symfony\Component\Form\Extension\Core\Type\FormType');
// $form = $builder->getForm();
$builder = $this->factory->createBuilder(
'Symfony\Component\Form\Extension\Core\Type\FormType',
null,
array(
'validation_groups' => 'group',
)
);
$builder->add('firstName', 'Symfony\Component\Form\Extension\Core\Type\FormType');
$form = $builder->getForm();

// $this->validator->expects($this->once())
// ->method('validate')
// ->with($this->equalTo($form))
// ->will($this->returnValue(new ConstraintViolationList()));
//
// // specific data is irrelevant
// $form->submit(array());
$this->validator->expects($this->once())
->method('validate')
->with($this->equalTo($form))
->will($this->returnValue(new ConstraintViolationList()));

// specific data is irrelevant
$form->submit(array());
}

public function testValidConstraint()
{
$form = $this->createForm(array('constraints' A20E => $valid = new Valid()));

$this->assertSame(array($valid), $form->getConfig()->getOption('constraints'));
}

// public function testValidConstraint()
// {
// $form = $this->createForm(array('constraints' => $valid = new Valid()));
//
// $this->assertSame(array($valid), $form->getConfig()->getOption('constraints'));
// }
public function testValidatorInterfaceSinceSymfony25()
{
$validator = $this->getMock('Symfony\Component\Validator\Validator\ValidatorInterface');

$formTypeValidatorExtension = new FormTypeValidatorExtension($validator);
$this->assertAttributeSame($validator, 'validator', $formTypeValidatorExtension);
}

// public function testValidatorInterfaceSinceSymfony25()
// {
// $validator = $this->getMock('Symfony\Component\Validator\Validator\ValidatorInterface');
//
// $formTypeValidatorExtension = new FormTypeValidatorExtension($validator);
// $this->assertAttributeSame($validator, 'validator', $formTypeValidatorExtension);
// }
//
// /**
// * @expectedException \InvalidArgumentException
// */
// public function testInvalidValidatorInterface()
// {
// new FormTypeValidatorExtension(null);
// }
/**
* @expectedException \InvalidArgumentException
*/
public function testInvalidValidatorInterface()
{
new FormTypeValidatorExtension(null);
}

protected function createForm(array $options = array())
{
Expand Down
0