8000 [BrowserKit] Added isFollowingRedirects and getMaxRedirects methods by Naktibalda · Pull Request #15697 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[BrowserKit] Added isFollowingRedirects and getMaxRedirects methods #15697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[BrowserKit] Added isFollowingRedirects and getMaxRedirects methods #15697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68d6956
[BrowserKit] Implemented getFollowRedirects and getMaxRedirects methods
Naktibalda Sep 4, 2015
5ec5a9e
Deleted unnecessary empty lines to satisfy fabbot
Naktibalda Sep 5, 2015
f6b7e7d
Renamed getFollowRedirects method to isFollowingRedirects
Naktibalda Sep 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Renamed getFollowRedirects method to isFollowingRedirects
  • Loading branch information
@Naktibalda
Naktibalda committed Sep 12, 2015
commit f6b7e7d7c14be4b80d58f42abec052ca19813f3c
4 changes: 2 additions & 2 deletions src/Symfony/Component/BrowserKit/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ public function followRedirects($followRedirect = true)
}

/**
* Returns whether client automatically follow redirects or not.
* Returns whether client automatically follows redirects or not.
*
* @return bool
*/
public function getFollowRedirects()
public function isFollowingRedirects()
{
return $this->followRedirects;
}
Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Component/BrowserKit/Tests/ClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,12 +492,12 @@ public function testFollowRedirectWithPort()
$this->assertEquals($headers, $client->getRequest()->getServer());
}

public function testGetFollowRedirects()
public function testIsFollowingRedirects()
{
$client = new TestClient();
$this->assertTrue($client->getFollowRedirects(), '->getFollowRedirects() returns default value');
$this->assertTrue($client->isFollowingRedirects(), '->getFollowRedirects() returns default value');
$client->followRedirects(false);
$this->assertFalse($client->getFollowRedirects(), '->getFollowRedirects() returns assigned value');
$this->assertFalse($client->isFollowingRedirects(), '->getFollowRedirects() returns assigned value');
}

public function testGetMaxRedirects()
Expand Down
0