8000 Introduce MetadataValidators to test arbitrary metadata for freshness. by bnw · Pull Request #15692 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Introduce MetadataValidators to test arbitrary metadata for freshness. #15692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
60b4089
Introduce MetadataValidators to test arbitrary metadata for freshness.
bnw Sep 3, 2015
673070b
Added trailing newline
bnw Sep 4, 2015
ab39129
Added new parameter to interface
bnw Sep 4, 2015
9546be9
Renamed ResourceValidator to ResourceInterfaceValidator
bnw Sep 4, 2015
0342b73
Added missing import
bnw Sep 4, 2015
7aee891
Correcting classname after renaming
bnw Sep 4, 2015
df526c0
Added ConfigCachePass to framework
bnw Sep 4, 2015
2555d5a
Fixed UnitTests
bnw Sep 4, 2015
4145dc0
Bugfix
bnw Sep 4, 2015
2e49fb2
Better name
bnw Sep 4, 2015
d0f1e2d
Fix test
mpdude Sep 5, 2015
3f9424f
Add docblock
mpdude Sep 5, 2015
b8bb60a
Fix tests while keeping ConfigCacheFactory unchanged (from a client p…
mpdude Sep 5, 2015
2fac8f3
Hello Fabbot
mpdude Sep 5, 2015
1b62130
Forgot import statement
mpdude Sep 5, 2015
b16d9de
The new ConfigCachePass is required
mpdude Sep 6, 2015
97a2cd0
Bump deps
mpdude Sep 6, 2015
aae0a78
Avoid changing the interface
mpdude Sep 6, 2015
024aa8c
Also validate this method in the interface
mpdude Sep 7, 2015
d617943
Rename ResourceInterfaceValidator to ResourceValidator as suggested o…
mpdude Sep 7, 2015
8907a21
Oh Fabbot
mpdude Sep 7, 2015
e471890
Add a note why the ResourceInterface::__toString method is important …
mpdude Sep 7, 2015
e9fd197
Remove totally broken test
mpdude Sep 7, 2015
53ad659
Rewrite ConfigCacheTest because it made many assumptions about how th…
mpdude Sep 7, 2015
594529c
Fix ConfigCache and improve docblock
mpdude Sep 7, 2015
32426ce
If I had to pay just $0.02 for every Fabbot complaint, Fabien would b…
mpdude Sep 7, 2015
f3470e3
Document deprecation in the CHANGELOG file
mpdude Sep 7, 2015
7739878
Some more tweaks to the ConfigCacheTest
mpdude Sep 7, 2015
f9c48a0
Remove unused import
mpdude Sep 7, 2015
c0f416d
Continue with next resource, not next validator
mpdude Sep 8, 2015
00b4efb
Add a shortcut for when we don't have any validators (might be in prod)
mpdude Sep 8, 2015
23a4464
Create a new ValidatorConfigCache class and pass metadata validators …
mpdude Sep 8, 2015
caf6bf1
Fabbot
mpdude Sep 8, 2015
37c96e1
This is not relevant for this PR
mpdude Sep 8, 2015
7bc5ba2
Tweaks as suggested on GH
mpdude Sep 8, 2015
f5add4c
Implement the plan(TM)
mpdude Sep 9, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
This is not relevant for this PR
  • Loading branch information
mpdude committed Sep 8, 2015
commit 37c96e16f8ffc48e74c5309e330d5e2ada05d5fe
5 changes: 0 additions & 5 deletions src/Symfony/Component/HttpKernel/Kernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -547,11 +547,6 @@ protected function initializeContainer()
$class = $this->getContainerClass();
$cache = new ConfigCache($this->getCacheDir().'/'.$class.'.php', $this->debug);
$fresh = true;

/* We probably should use the ConfigCacheFactory here, but that would require
* some wrapper methods because we cannot call protected methods from closures
* prior to PHP 5.4. Let's do this change later when we can require PHP 5.4.
*/
if (!$cache->isFresh()) {
$container = $this->buildContainer();
$container->compile();
Expand Down
0