10000 [SecurityBundle] Skip SetAclCommandTest when sqlite is not available by nicolas-grekas · Pull Request #15631 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Skip SetAclCommandTest when sqlite is not available #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2015
Merged

[SecurityBundle] Skip SetAclCommandTest when sqlite is not available #15631

merged 1 commit into from
Aug 27, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@linaori
Copy link
Contributor
linaori commented Aug 27, 2015

Because I'm extracting this for the bundle, I've added this change to the PR I'm making for the split.
https://github.com/iltar/AclBundle/commit/7bb96e7f8a9495315588fc8bfb2ec66beb3d978b

edit: Amended, there's a second setUp method in that class.

@nicolas-grekas
Copy link
Member Author

@iltar good idea. Note that I also just moved the tearDown function on the top of the class.

@nicolas-grekas nicolas-grekas merged commit 95961a5 into symfony:2.7 Aug 27, 2015
nicolas-grekas added a commit that referenced this pull request Aug 27, 2015
@nicolas-grekas
minor #15631 [SecurityBundle] Skip SetAclCommandTest when sqlite is n…
8ae3dec 
…ot available (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[SecurityBundle] Skip SetAclCommandTest when sqlite is not available

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

95961a5 [SecurityBundle] Skip SetAclCommandTest when sqlite is not available
6B27
@nicolas-grekas nicolas-grekas deleted the win-fixes branch August 31, 2015 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @linaori @carsonbot
0