8000 [Translator][warmup][fallback locales] fixed missing cache file generation. by aitboudad · Pull Request #15516 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translator][warmup][fallback locales] fixed missing cache file generation. #15516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2015
Merged

[Translator][warmup][fallback locales] fixed missing cache file generation. #15516

merged 1 commit into from
Sep 10, 2015

Conversation

aitboudad
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #15364
Tests pass? yes
License MIT

@aitboudad aitboudad mentioned this pull request Aug 12, 2015
Closed
stof
stof reviewed Aug 12, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Tests/Translation/TranslatorTest.php
@@ -273,7 +273,7 @@ public function testWarmup()

// prime the cache
$translator = $this->getTranslator($loader, array('cache_dir' => $this->tmpDir, 'resource_files' => $resourceFiles), 'yml');
$translator->setLocale('fr');
$translator->setFallbackLocales(['fr']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no short array syntax. We support PHP 5.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

habits :)

@aitboudad aitboudad force-pushed the translator_warmup_fallback branch 2 times, most recently from 1f5f994 to 2cdaf9f Compare August 12, 2015 16:02
@aitboudad aitboudad force-pushed the translator_warmup_fallback branch from 2cdaf9f to 8dedd67 Compare September 4, 2015 10:41
@aitboudad
Copy link
Contributor Author

ping @symfony/deciders

@aitboudad aitboudad force-pushed the translator_warmup_fallback branch from 8dedd67 to cade651 Compare September 9, 2015 14:58
@aitboudad aitboudad merged commit cade651 into symfony:2.7 Sep 10, 2015
aitboudad added a commit that referenced this pull request Sep 10, 2015
@aitboudad
bug #15516 [Translator][warmup][fallback locales] fixed missing cache…
2ae2714 
… file generation. (aitboudad)

This PR was merged into the 2.7 branch.

Discussion
----------

[Translator][warmup][fallback locales] fixed missing cache file generation.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #15364
| Tests pass?   | yes
| License       | MIT

Commits
-------

cade651 [Translator][warmup][fallback locales] fixed missing cache file generation.
@aitboudad aitboudad deleted the translator_warmup_fallback branch September 10, 2015 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready Status: Reviewed Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @stof @carsonbot
0