[Validator] Require the intl extension to be installed for one of the test cases #15444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test cases Requiring a specific version of the intl data is not sufficient, we need the extension to be installed.
|
Looks like these tests are skipped on travis. |
|
why do we need the full Intl ? The stub should be enough as we don't test in another locale |
|
I need to double check if tests actually expect correct values. |
|
Imo we can close this one, superseded by #15575 |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Add appveyor.yml for C.I. on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)! | Fixed tickets | #13934, #15049, #14259, #15045, #15444 | License | MIT | Doc PR | symfony/symfony-docs#5654 - testing two matrix lines: - one without mbtring nor fileinfo nor intl - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component - bug fixes thanks to these harder testing conditions - some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes). Commits ------- ea5d656 Windows and Intl fixes 8bbd8d9 Add appveyor.yml for C.I. on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring a specific version of the intl data is not sufficient, we need the extension to be installed.