[Serializer] Add support for variadic arguments in the GetSetNormalizer #15426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (method_exists($constructorParameter, 'isVariadic') && $constructorParameter->isVariadic()) { | ||
| if (isset($normalizedData[$paramName])) { | ||
| if (!is_array($normalizedData[$paramName])) { | ||
| throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because the variadic parameter %s can only accept an array.', $class, $constructorParameter->name)); |
|
👍 |
|
This patch must also be applied to 👍 |
|
there is no PropertyNormalizer in 2.3 |
|
👍 |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2015
…SetNormalizer (stof) This PR was merged into the 2.3 branch. Discussion ---------- [Serializer] Add support for variadic arguments in the GetSetNormalizer | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a There were 2 broken cases: - when the value was passed, the array was passed as argument, becoming the first value of the variadic array. The array needs to be spread into multiple arguments when calling the method - when the value was missing, the code would throw a ReflectionException, similar to the issue reported in #13690, because a variadic argument is optional but does not have a default value Commits ------- 704760b Add support for variadic arguments in the GetSetNormalizer
|
@stof Can you merge 2.3 into 2.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 broken cases: