[Routing] Fix the retrieval of the default value for variadic arguments in the annotation loader #15425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no variadic default values and that generate a fatal error.
|
Actually, I'm wondering whether we need more changes to support variadic arguments properly in case values are passed. |
|
👍 |
|
Thanks Christophe. |
Tobion
added a commit
that referenced
this pull request
Aug 2, 2015
…dic arguments in the annotation loader (wdalmut, stof) This PR was merged into the 2.3 branch. Discussion ---------- [Routing] Fix the retrieval of the default value for variadic arguments in the annotation loader | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13690 | License | MIT | Doc PR | n/a This takes the test submitted in #13690 and implements the fix for this bug Commits ------- 73c5eff Fix the retrieval of the default value for variadic arguments 9b7d4c7 Annotated routes with a variadic parameter
|
@Tobion do you know when this will be merged also into branch 2.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the test submitted in #13690 and implements the fix for this bug