8000 [Debug] cleanup ExceptionHandlerTest by nicolas-grekas · Pull Request #15417 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Debug] cleanup ExceptionHandlerTest #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2015
Merged

[Debug] cleanup ExceptionHandlerTest #15417

merged 1 commit into from
Aug 1, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas force-pushed the clean-tests branch 4 times, most recently from cc0d259 to 3bc3c1c Compare July 31, 2015 14:25
@nicolas-grekas nicolas-grekas changed the title [Debug] cleanup some tests [Debug] cleanup ExceptionHandlerTest Jul 31, 2015
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 31, 2015
Merged
fabpot
fabpot reviewed Jul 31, 2015
View reviewed changes
src/Symfony/Component/Debug/composer.json
"suggest": {
"symfony/http-foundation": "",
"symfony/http-kernel": ""
"symfony/http-kernel": "~2.3.24|~2.5.9|~2.6,>=2.6.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never suggest versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You read too fast, this removes the suggest section

@fabpot
Copy link
Member
fabpot commented Aug 1, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 51bacc6 into symfony:2.7 Aug 1, 2015
fabpot added a commit that referenced this pull request Aug 1, 2015
@fabpot
minor #15417 [Debug] cleanup ExceptionHandlerTest (nicolas-grekas)
9058904 
This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] cleanup ExceptionHandlerTest

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

51bacc6 [Debug] cleanup ExceptionHandlerTest
@nicolas-grekas nicolas-grekas deleted the clean-tests branch August 1, 2015 06:35
5EDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot
0