Remove skipping of tests based on ICU data version whenever possible #15412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -271,16 +270,6 @@ public function testInitializeWithDateTime() | |||
| $this->factory->create('datetime', new \DateTime()); | |||
| } | |||
|
|
|||
| public function testSingleTextWidgetShouldUseTheRightInputType() | |||
There was a problem hiding this comment.
this test is actually a duplicate of another one
|
OK, looks like |
|
given this is an internal class used only by the script updating the ICU data, I will just skip these tests on HHVM (as done on old PHP 5.3 versions) |
Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used.
|
Looks like we have a time-sensitive test in the HttpCacheTest |
|
Thank you @stof. |
7994513
into
symfony:2.3
fabpot
added a commit
that referenced
this pull request
Aug 1, 2015
…ver possible (stof) This PR was merged into the 2.3 branch. Discussion ---------- Remove skipping of tests based on ICU data version whenever possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used. this is somewhat related to #14259 as it allows to reduce the number of tests not running on Travis. Commits ------- 7994513 Remove skipping of tests based on ICU data version whenever possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used.
this is somewhat related to #14259 as it allows to reduce the number of tests not running on Travis.