8000 Remove skipping of tests based on ICU data version whenever possible by stof · Pull Request #15412 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Remove skipping of tests based on ICU data version whenever possible #15412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2015

Conversation

stof
Copy link
Member
@stof stof commented Jul 30, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used.

this is somewhat related to #14259 as it allows to reduce the number of tests not running on Travis.

@@ -271,16 +270,6 @@ public function testInitializeWithDateTime()
$this->factory->create('datetime', new \DateTime());
}

public function testSingleTextWidgetShouldUseTheRightInputType()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is actually a duplicate of another one

@stof
Copy link
Member Author
stof commented Jul 30, 2015

OK, looks like ResourceBundle does not handle loading with fallback disabled in the same way than PHP

@stof
Copy link
Member Author
stof commented Jul 30, 2015

given this is an internal class used only by the script updating the ICU data, I will just skip these tests on HHVM (as done on old PHP 5.3 versions)

Many tests being skipped based on the ICU data version don't actually
need it. They might be testing code paths not relying on Intl, or not
performing assertions on the values depending on the ICU data and so not
dependant on the exact ICU version being used.
@stof
Copy link
Member Author
stof commented Jul 30, 2015

Looks like we have a time-sensitive test in the HttpCacheTest

@fabpot
Copy link
Member
fabpot commented Aug 1, 2015

Thank you @stof.

@fabpot fabpot merged commit 7994513 into symfony:2.3 Aug 1, 2015
fabpot added a commit that referenced this pull request Aug 1, 2015
…ver possible (stof)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove skipping of tests based on ICU data version whenever possible

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used.

this is somewhat related to #14259 as it allows to reduce the number of tests not running on Travis.

Commits
-------

7994513 Remove skipping of tests based on ICU data version whenever possible
@stof stof deleted the no_intl_skip branch September 20, 2015 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0