[Asset] removed unused private property. #15367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
Looks correct to me. Status: Reviewed |
| @@ -62,7 +61,7 @@ public function __construct($baseUrls = array(), VersionStrategyInterface $versi | |||
| $sslUrls = $this->getSslUrls($baseUrls); | |||
|
|
|||
| if ($sslUrls && $baseUrls !== $sslUrls) { | |||
| $this->sslPackage = new UrlPackage($sslUrls, $versionStrategy); | |||
| $this->sslPackage = new self($sslUrls, $versionStrategy); | |||
There was a problem hiding this comment.
No, but it's easier when renaming the class name and apart from that, works exactly the same.
There was a problem hiding this comment.
Fabbot.io forced to me to change it to new self to make the build pass. Looks like that's one of our coding conventions :)
|
👍 |
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Jul 26, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Asset] removed unused private property. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- a1772b6 [Asset] removed unused private property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.