8000 [HttpFoundation] fixed the check of 'proxy-revalidate' in Response::mustRevalidate() by axiac · Pull Request #15263 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] fixed the check of 'proxy-revalidate' in Response::mustRevalidate() #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[HttpFoundation] fixed the check of 'proxy-revalidate' in Response::mustRevalidate() #15263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c980c3f
[HttpFoundation] fixed the check of 'proxy-revalidate' in Response::m…
axiac Jul 11, 2015
e799be3
[HttpFoundation] fixed the check of 'proxy-revalidate' - added tests
axiac Aug 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[HttpFoundation] fixed the check of 'proxy-revalidate' in Response::m… 
…ustRevalidate()

'proxy-revalidate' is not a header on its own but a 'Cache-Control' directive
See http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.9

This fixes issue #15262
  • Loading branch information
@axiac
axiac committed Jul 30, 2015
commit c980c3f6905d8627025d6982e3801a933d79c028
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ public function setPublic()
*/
public function mustRevalidate()
{
return $this->headers->hasCacheControlDirective('must-revalidate') || $this->headers->has('proxy-revalidate');
return $this->headers->hasCacheControlDirective('must-revalidate') || $this->headers->hasCacheControlDirective('proxy-revalidate');
}

/**
Expand Down
0