8000 Fix quoting style consistency. by ogizanagi · Pull Request #15129 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ogizanagi
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is a really minor change with reference to this comment.

If it's fine, those changes for 2.7 will follow up too.

@fabpot
Copy link
Member
fabpot commented Jun 28, 2015

Thank you @ogizanagi.

@fabpot fabpot merged commit 57d30f9 into symfony:2.3 Jun 28, 2015
fabpot added a commit that referenced this pull request Jun 28, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Fix quoting style consistency.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is a really minor change with reference to [this comment](#15002 (comment)).

If it's fine, [those changes](symfony:2.7...ogizanagi:fix_quoting_style/2.7) for 2.7 will follow up too.

Commits
-------

57d30f9 Fix quoting style consistency.
@ogizanagi ogizanagi deleted the fix_quoting_style/2.3 branch June 28, 2015 17:09
@ogizanagi
Copy link
Contributor Author

@fabpot : Here is the PR for 2.7: #15136

fabpot added a commit that referenced this pull request Jun 28, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

Fix quoting style consistency (2.7)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Follows up #15129.

Commits
-------

2aab007 Fix quoting style consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0