fixed #15118 [Filesystem] mirroring a symlink copies absolute file path #15121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be applied on 2.3? |
|
This issue first appears in 2.5, but since 2.5 is EOL I think this should be fixed in 2.6. |
|
wouldn't this cause issues if the mirrored files is a relative symlink to a file which is not mirrored to have an equivalent in the new location ? |
|
Sure, in that case the symlink would break, but I'd argue that you're also using it wrong :) If the symlink needs to be to an absolute location (i.e. one that will not be mirrored), it should be absolute in the first place. What doesn't make sense (at least to me) is for symfony to make that decision for you and convert a relative symlink into an absolute one with no choice or warning. |
|
Thank you @danepowell. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
…ute file path (danepowell) This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #15121). Discussion ---------- fixed #15118 [Filesystem] mirroring a symlink copies absolute file path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15118 | License | MIT | Doc PR | This reverts the code change in a8b8d33 and adjusting the test case accordingly. Commits ------- a83d525 fixed #15118 [Filesystem] mirroring a symlink copies absolute file path
|
merged into 2.3. |
This was referenced Oct 27, 2015
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the code change in a8b8d33 and adjusting the test case accordingly.