Bug #14836 [HttpFoundation] Moves default JSON encoding assignment #14918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om constructor to property
|
This syntax is only possible since php 5.6: http://3v4l.org/goRvS |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2015
…signment fr… (Incognito) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #14930). Discussion ---------- Bug #14836 [HttpFoundation] Moves default JSON encoding assignment fr… | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #14918, #14836 | License | MIT | Doc PR | no Moves the assignment of the encoding flags to a property so the class can be extended without needing to re-write the constructor and perform the encoding of data twice. For more information please see #14836 Commits ------- 25e0d63 Bug #14836 [HttpFoundation] Moves default JSON encoding assignment from constructor to property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the assignment of the encoding flags to a property so the class can be extended without needing to re-write the constructor and perform the encoding of data twice.
For more information please see #14836