-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Adding notes about deprecated warnings in 2.7 #14776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the doc, we also need to tell to actually read the deprecations and upgrade their code as required! |
@nicolas-grekas definitely right - I got that at symfony/symfony-docs#5329 - but I'm happy to make any additions/tweaks if you see any. |
If we can get a few 👍 on this, then we can go ahead and merge it. I know it's just docs, but important to make sure i've got the facts right :) |
Thank you @weaverryan. |
This PR was merged into the 2.7 branch. Discussion ---------- Adding notes about deprecated warnings in 2.7 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Hi guys! When I upgraded, my project exploded with deprecated warnings. I'm certain we'll get a lot of questions about these, so I think we should try to get ahead of these questions as much as possible. I'm adding this - if I'm mistaken in anything, please let me know. I also think we should mention this in the release blog post so that people are aware. I'm about to propose a short docs entry to explain things there too (so that hopefully if someone googles for the issue, they'll find our explanation). Thanks! Commits ------- e374274 Adding notes about deprecated warnings in 2.7
What about people who do not use |
@Tobion The first part of the note is about adding |
I guess it's about sensiolabs/SensioDistributionBundle#201. This logic should have been added to https://github.com/symfony/symfony-standard/blob/2.7/web/app.php instead of the bootstrap file. |
@Tobion I understand what you mean now. We should leave things as-is for now (too quick to change before the release), and argue for adding it to the SE in a separate pull request. I think it needs to be included in "dev" mode and the console too - otherwise my console explodes with warnings :). So, |
This PR was squashed before being merged into the 2.8 branch (closes #854). Discussion ---------- extract autoloading out from bootstrap Fixes https://github.com/symfony/symfony-standard/issues/788#issuecomment-98993898 and symfony/symfony#14776 (comment). - by default class aggregation is still used as it is probably beneficial by default for most people (no opcache at all or stats enabled) - People that do not want to use the aggregation, can simply comment the line. They do not have to rewrite code. E.g. when using opcache with `opcache.validate_timestamps=0` in production there is no point in using the bootstrap. - No debugging hell anymore as the class aggregation is only done in in no-debug mode - All environments still use the same code path, i.e. load autoload first. The only difference is the inlusion of the aggregation. - This way we can also simplify the bootstrap generation in the distribution bundle in the next major version of it. - several imrprovements like using `require` instead of `require_once` for the autoloader to rely on the return value and `include_once` instead of `require_once` for the bootstrap as the app is also working without it Commits ------- 747a384 extract autoloading out from bootstrap
Hi guys!
When I upgraded, my project exploded with deprecated warnings. I'm certain we'll get a lot of questions about these, so I think we should try to get ahead of these questions as much as possible. I'm adding this - if I'm mistaken in anything, please let me know. I also think we should mention this in the release blog post so that people are aware.
I'm about to propose a short docs entry to explain things there too (so that hopefully if someone googles for the issue, they'll find our explanation).
Thanks!