8000 [HttpFoundation] Add missing Response::getStatusText() method. by dunglas · Pull Request #14770 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Add missing Response::getStatusText() method. #14770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Add missing Response::getStatusText() method. #14770

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented May 28, 2015
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Proposed as new feature but would be nice to have it as "bug fix" in 2.3 for the http bridge.

@Tobion
Copy link
Contributor
Tobion commented May 28, 2015

#14421 (comment) ;)

@dunglas
Copy link
Member Author
dunglas commented May 28, 2015

I've not seen this one :) But we have the valid use case now:

What do you think @fabpot?

@dunglas
Copy link
Member Author
dunglas commented May 28, 2015

symfony/psr-http-message-bridge#1 (comment)

@fabpot
Copy link
Member
fabpot commented May 28, 2015

I'm strongly against this change because the status text has no meaning in the HTTP spec. And PSR is flawed here. I mentioned my concerns but people disagreed. That's life.

@fabpot fabpot closed this Aug 1, 2015
@dosten dosten mentioned this pull request Aug 12, 2015
Closed
@shakaran
Copy link
Contributor

@fabpot for me has meaning since I check the status code in unit test, but also I would like check the status text received since you have some fake request made for bots or you can inject some text responses in status text

@dunglas dunglas deleted the status_text branch December 5, 2015 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @Tobion @fabpot @shakaran
0