[HttpKernel] use ConfigCache::getPath() method when it exists #14610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the deprecated `__toString()` method of the `ConfigCache` class will not be called.
215c42b to
ab70632
Compare
|
👍 wouldn't be better to use |
|
@aitboudad The instance is passed to the method. What exactly do you propose to change there? |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 11, 2015
…xists (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] use ConfigCache::getPath() method when it exists | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This way, the deprecated `__toString()` method of the `ConfigCache` class will not be called. Commits ------- ab70632 [HttpKernel] use ConfigCache::getPath() method when it exists
|
@aitboudad #14178 is already merged, isn't it? |
|
@xabbuh yes, but I think we have forgotten to apply the changes in |
|
@aitboudad I'm afraid I still don't understand what you mean. Maybe it's better if you create a PR. :) |
|
@xabbuh 😄 ok I'll try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the deprecated
__toString()method of theConfigCacheclass will not be called.