8000 Fixed getRoles() return PHPDoc value by mmoreram · Pull Request #14471 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fixed getRoles() return PHPDoc value #14471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed getRoles() return PHPDoc value #14471

wants to merge 1 commit into from

Conversation

mmoreram
Copy link
Contributor
  • This method returns an array of strings instead of Role instances as is shown in the description of the method.
  • The use statement has been removed as well because is not used anymore.
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@mmoreram
Fix the PHPDoc for the getRoles() method
478ca37 
This method return an array of strings instead of Role instances.
I have removed as well the use statement because is not used anymore.

| Q             | A
| ------------- | ---
| Bug fix?      | [yes]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [yes]
| Fixed tickets |
| License       | MIT
| Doc PR        |
@dosten
Copy link
Contributor
dosten commented Apr 26, 2015

getRoles can return an array of strings, Role instances or a mix of both, the phpdoc must reflect that. See #13146 for a previous discussion.

@fabpot fabpot closed this May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoreram @dosten @fabpot
0