[2.3][Translation] test refresh cache when resources File change. #14279
Conversation
3b00bb7 to
4d01fab
Compare
|
@mpdude I made an update that refer to your comment, is it ok :) ? |
|
👍 for the "expect never" change. Besides that, I wouldn't touch the cache file. How that works (and what effects it has) is an implementation detail of the Maybe someone else can comment? |
|
it seems to be OK, I'll merge it. |
|
Disregard my previous comment – I was looking at an outdated version of the "Files changed" tab. Sorry. |
…e change. (aitboudad) This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Translation] test refresh cache when resources File change. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT For 2.6 #14280 Commits ------- 4d01fab [2.3][Translation] test refresh cache when resources File change.
|
@aitboudad It seems that this PR makes builds for the low deps fail on higher branches. Do you have an idea what's going wrong there? |
| ->will($this->returnValue(false)) | ||
| ; | ||
| $catalogue = $this->getCatalogue('fr', array('foo' => 'foo fresh')); | ||
| $catalogue->addResource($resource); |
There was a problem hiding this comment.
@xabbuh haven't looked at it in detail, but I think this resource mock has no effect. Instead the resource already serialized in the cache will be loaded (and still be fresh)?
|
Have a look at the testCatalogueIsReloadedWhenResourcesAreNoLongerFresh() Method in #14291 where I do something similar, maybe that helps? |
|
I'll look into it :) |
|
fixed in #14344 |
… no longer fresh. (aitboudad) This PR was merged into the 2.3 branch. Discussion ---------- [Translation][fixed test] refresh cache when resources are no longer fresh. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #14279 | Tests pass? | yes | License | MIT Commits ------- 04b8e4e [Translation][fixed test] refresh cache when resources are no longer fresh.
For 2.6 #14280