8000 [Form] Fixed DateType/TimeType by webmozart · Pull Request #14256 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Form] Fixed DateType/TimeType #14256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2015
Merged

Conversation

webmozart
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12808
License MIT
Doc PR -

In 849fb29, support for the "model_timezone" and "view_timezone" options was removed from DateType and TimeType. In 1c4a75a, this change was reverted, but only partially, leaving the tests in a broken state and leading to bugs such as described in #12808 (I have no idea why this bug report is closed, when the bug still seems to be present to me).

This PR fixes both types.

@fabpot
Copy link
Member
fabpot commented Apr 8, 2015

Thank you @webmozart.

@fabpot fabpot merged commit 060d0f8 into symfony:2.6 Apr 8, 2015
fabpot added a commit that referenced this pull request Apr 8, 2015
This PR was merged into the 2.6 branch.

Discussion
----------

[Form] Fixed DateType/TimeType

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12808
| License       | MIT
| Doc PR        | -

In 849fb29, support for the "model_timezone" and "view_timezone" options was removed from DateType and TimeType. In 1c4a75a, this change was reverted, but only partially, leaving the tests in a broken state and leading to bugs such as described in #12808 (I have no idea why this bug report is closed, when the bug still seems to be present to me).

This PR fixes both types.

Commits
-------

060d0f8 [Form] Fixed DateType/TimeType that were broken since 849fb29 and 1c4a75a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0