[VarDumper] Towards PHP7 support #14204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,23 +70,23 @@ public static function castErrorException(\ErrorException $e, array $a, Stub $st | |||
|
|
|||
| public static function castThrowingCasterException(ThrowingCasterException $e, array $a, Stub $stub, $isNested) | |||
| { | |||
| $b = (array) $a["\0Exception\0previous"]; | |||
| $b = (array) $a[$xPrefix.'previous']; | |||
There was a problem hiding this comment.
indeed, fixed, thanks
240335f to
8d5f480
Compare
| @@ -81,7 +80,7 @@ public function testGet() | |||
| </samp>} | |||
| "<span class=sf-dump-key>closure</span>" => <span class=sf-dump-note>Closure</span> {<a class=sf-dump-ref>#%d</a><samp> | |||
| <span class=sf-dump-meta>reflection</span>: """ | |||
| <span class=sf-dump-str title="%d characters">Closure [ <user> {$closureLabel} Symfony\Component\VarDumper\Tests\Fixture\{closure} ] {</span> | |||
| <span class=sf-dump-str title="%d characters">Closure [ <user> %s | |||
There was a problem hiding this comment.
you should keep the closing space as part of the assertion
d0f923d to
be98abd
Compare
be98abd to
df484da
Compare
|
This PR is ready. The last failing test should be fixed once https://bugs.php.net/69376 is. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 4, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [VarDumper] Towards PHP7 support | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - That's a start Commits ------- df484da [VarDumper] Towards PHP7 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a start