8000 Removed deprecations in Console component by saro0h · Pull Request #14118 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Removed deprecations in Console component #14118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2015
Merged

Removed deprecations in Console component #14118

merged 1 commit into from
Mar 31, 2015

Conversation

@saro0h

Copy link
Contributor
@saro0h saro0h commented Mar 30, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR ~

xabbuh
xabbuh reviewed Mar 30, 2015
View reviewed changes
src/Symfony/Component/Console/Tests/Input/StringInputTest.php Outdated
Copy link
Member
@xabbuh xabbuh Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the whole test (it's the same as testInputOptionWithGivenString above now).

@saro0h saro0h force-pushed the deprecation-console branch from f8d9da2 to 465bf6a Compare March 30, 2015 21:43
@saro0h saro0h force-pushed the deprecation-console branch from 465bf6a to 1a8f87d Compare March 30, 2015 21:45
@fabpot
Copy link
Member
fabpot commented Mar 31, 2015

Thank you @saro0h.

@fabpot fabpot merged commit 1a8f87d into symfony:master Mar 31, 2015
fabpot added a commit that referenced this pull request Mar 31, 2015
@fabpot
feature #14118 Removed deprecations in Console component (saro0h)
e01a9a6 
This PR was merged into the 3.0-dev branch.

Discussion
----------

Removed deprecations in Console component

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | ~

Commits
-------

1a8f87d Removed deprecations in Console component
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saro0h @fabpot @xabbuh
0