10000 [Enhancement] netbeans - force interactive shell when limited detection by cordoval · Pull Request #14102 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Enhancement] netbeans - force interactive shell when limited detection #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Enhancement] netbeans - force interactive shell when limited detection #14102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22430af
[Enhancement] netbeans - force interactive shell when limited detection
cordoval Mar 29, 2015
5bcd576
simplify equality to inequality expression on SHELL_INTERACTIVE
cordoval Mar 29, 2015
4b8448e
update depending on getenv returning false
cordoval Apr 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify equality to inequality expression on SHELL_INTERACTIVE
  • Loading branch information
@cordoval
cordoval committed Apr 3, 2015
commit 5bcd576dd9325769748ff237a98e6238ee6c3ad5
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ protected function configureIO(InputInterface $input, OutputInterface $output)
$input->setInteractive(false);
} elseif (function_exists('posix_isatty') && $this->getHelperSet()->has('dialog')) {
$inputStream = $this->getHelperSet()->get('dialog')->getInputStream();
if (!@posix_isatty($inputStream) && !(true === getenv('SHELL_INTERACTIVE'))) {
if (!@posix_isatty($inputStream) && true !== getenv('SHELL_INTERACTIVE')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getenv can return a string or false when the env var is not set. But it cannot be true

$input->setInteractive(false);
}
}
Expand Down
0