8000 [Translation] keep old array structure of resourcesFiles to avoid BC. by aitboudad · Pull Request #14022 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] keep old array structure of resourcesFiles to avoid BC. #14022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2015
Merged

[Translation] keep old array structure of resourcesFiles to avoid BC. #14022

merged 1 commit into from
Mar 24, 2015

Conversation

aitboudad
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #13897
Tests pass? yes
License MIT

@aitboudad
Copy link
Contributor Author

related to liip/LiipTranslationBundle#36

@stof
Copy link
Member
stof commented Mar 23, 2015

does this allow to preserve the performance improvement or no ?

@aitboudad
Copy link
Contributor Author

yes, as we don't load them in prod env.

@aitboudad aitboudad mentioned this pull request Mar 23, 2015
Merged
@fabpot
8000
Copy link
Member
fabpot commented Mar 24, 2015

Thank you @aitboudad.

@fabpot fabpot merged commit aa70a94 into symfony:2.7 Mar 24, 2015
fabpot added a commit that referenced this pull request Mar 24, 2015
@fabpot
minor #14022 [Translation] keep old array structure of resourcesFiles…
2f39901 
… to avoid BC. (aitboudad)

This PR was merged into the 2.7 branch.

Discussion
----------

[Translation] keep old array structure of resourcesFiles to avoid BC.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #13897
| Tests pass?   | yes
| License       | MIT

Commits
-------

aa70a94 [Translation] keep old array structure of resourcesFiles to avoid BC.
@fabpot fabpot mentioned this pull request Mar 24, 2015
Merged
@aitboudad aitboudad deleted the translation_resources_fix_bc branch March 24, 2015 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @stof 3330 @fabpot
0