[WebProfilerBundle] Fix javascript toolbar on IE8 #13978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I forgot to mention that, yes, I do love using Symfony toolbar on internet explorer :) |
15e2da8 to
cbd89f5
Compare
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2015
…eutron) This PR was merged into the 2.6 branch. Discussion ---------- [WebProfilerBundle] Fix javascript toolbar on IE8 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A - `Array.prototype.slice.call(tbody.children);` called on HTMLCollection throws an error on IE8 - `XMLHttpRequest` has no event handler on IE8 - `document.getElementsByClassName` does not exist on IE8 Commits ------- cbd89f5 [WebProfilerBundle] Fix javascript toolbar on IE8
fabpot
added a commit
that referenced
this pull request
Apr 2, 2015
This PR was merged into the 2.6 branch. Discussion ---------- Fix the AJAX profiling | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | reported in #13447 (comment) | License | MIT | Doc PR | n/a The fix for IE8 (#13978) which does not have the addEventListener method on XMLHttpRequest broke the feature for modern browsers because it was checking the existence on the wrong object. It is a method on the instance, not on the "class", and so should be checked on the prototype. Commits ------- 9d6c0b1 Fix the AJAX profiling
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…romainneutron) This PR was merged into the 2.6 branch. Discussion ---------- [WebProfilerBundle] Fix javascript toolbar on IE8 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A - `Array.prototype.slice.call(tbody.children);` called on HTMLCollection throws an error on IE8 - `XMLHttpRequest` has no event handler on IE8 - `document.getElementsByClassName` does not exist on IE8 Commits ------- cbd89f5 [WebProfilerBundle] Fix javascript toolbar on IE8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array.prototype.slice.call(tbody.children);called on HTMLCollection throws an error on IE8XMLHttpRequesthas no event handler on IE8document.getElementsByClassNamedoes not exist on IE8