8000 [FrameworkBundle][debug:config] added support for dynamic configurations... by aitboudad · Pull Request #13886 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][debug:config] added support for dynamic configurations... #13886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2015
Merged

[FrameworkBundle][debug:config] added support for dynamic configurations... #13886

merged 1 commit into from
Mar 23, 2015

Conversation

aitboudad
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #12438
Tests pass? yes
License MIT

@aitboudad aitboudad mentioned this pull request Mar 22, 2015
Closed
stloyd
stloyd reviewed Mar 22, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDebugCommandTest.php
$tester = $this->createCommandTester();
$ret = $tester->execute(array('name' => 'TestBundle'));

$this->assertEquals(0, $ret, 'Returns 0 in case of success');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertSame()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fabpot
Copy link
Member
fabpot commented Mar 23, 2015

Thank you @aitboudad.

@fabpot fabpot merged commit 0f9eb7a into symfony:2.6 Mar 23, 2015
fabpot added a commit that referenced this pull request Mar 23, 2015
@fabpot
bug #13886 [FrameworkBundle][debug:config] added support for dynamic …
39da732 
…configurations... (aitboudad)

This PR was merged into the 2.6 branch.

Discussion
----------

[FrameworkBundle][debug:config] added support for dynamic configurations...

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #12438
| Tests pass?   | yes
| License       | MIT

Commits
-------

0f9eb7a [FrameworkBundle][debug:config] added support for dynamic configurations.
@aitboudad aitboudad deleted the issue_12438 branch March 23, 2015 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @fabpot @stloyd
0