[2.1] Decouple mimetype-to-extension logic from File class #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -467,7 +50,7 @@ class File extends \SplFileInfo | |||
| { | |||
| $type = $this->getMimeType(); | |||
|
|
|||
| return isset(static::$defaultExtensions[$type]) ? static::$defaultExtensions[$type] : null; | |||
| return ExtensionGuesser::guessExtension($type); | |||
There was a problem hiding this comment.
you should not use a static method. This does not allow to replace the guesser implementation
|
Now implemented similarly to the existing MimeTypeGuesser. |
| * @return string The guessed extension or NULL, if none could be guessed | ||
| */ | ||
| function guess($mimeType); | ||
|
|
|
whitespace removed |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2011
Commits ------- 34494b3 whitespace fixes 1a86a4a Refactor mime-type to file extension guessing e7481a3 Decouple mime-type to extension logic from File class Discussion ---------- [2.1] Decouple mimetype-to-extension logic from File class This allows guessing the extension from a given mime type without requiring the existence of a local file. If a file's meta information (mime-type, etc.) is already available (i.e. it's been extracted once and stored in some persistent data store), it would be nice to be able to make a best-guess on the extension based on the known mime-type. A concrete use case of this is for the symfony-cmf, where a file has been stored in the jackrabbit data store. When delivering this file or saving it to disk, we'd like to use an extension that's created based on the known mime type of the file. --------------------------------------------------------------------------- by brki at 2011/06/21 04:35:13 -0700 Now implemented similarly to the existing MimeTypeGuesser. --------------------------------------------------------------------------- by brki at 2011/06/21 07:51:22 -0700 whitespace removed --------------------------------------------------------------------------- by stof at 2011/09/04 05:04:54 -0700 @fabpot @brki what is the status of this PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows guessing the extension from a given mime type
without requiring the existence of a local file.
If a file's meta information (mime-type, etc.) is already available (i.e. it's
been extracted once and stored in some persistent data store), it would be
nice to be able to make a best-guess on the extension based on the known mime-type.
A concrete use case of this is for the symfony-cmf, where a file has been stored
in the jackrabbit data store. When delivering this file or saving it to disk, we'd like to
use an extension that's created based on the known mime type of the file.