8000 [PropertyAccess] stop overwriting once a reference is reached (3rd) by bananer · Pull Request #13835 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] stop overwriting once a reference is reached (3rd) #13835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[PropertyAccess] stop overwriting once a reference is reached (3rd) #13835

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b95ffd1
[PropertyAccess] add test case for property with only getter, no setter
bananer Mar 2, 2015
42ad722
[PropertyAccess] Add test cases for nested objects and arrays
bananer Mar 2, 2015
15b890f
[PropertyAccess] stop overwriting once a reference is reached
bananer Mar 2, 2015
c3eedcb < 8000 div class="text-emphasized css-truncate css-truncate-target"> [PropertyAccess] return as soon as possible from setValue and isWritable
bananer Mar 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[PropertyAccess] stop overwriting once a reference is reached
  • Loading branch information
@bananer
bananer committed Mar 3, 2015
commit 15b890f15b83e197149fbe3ce80cf12165f8f925
7 changes: 4 additions & 3 deletions src/Symfony/Component/PropertyAccess/PropertyAccessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ public function setValue(&$objectOrArray, $propertyPath, $value)
} else {
$this->writeProperty($objectOrArray, $property, $value);
}

$overwrite = !$propertyValues[$i][self::IS_REF];
}

$value = & $objectOrArray;
$overwrite = !$propertyValues[$i][self::IS_REF];
}
}

Expand Down Expand Up @@ -150,9 +151,9 @@ public function isWritable($objectOrArray, $propertyPath)
return false;
}
}
}

$overwrite = !$propertyValues[$i][self::IS_REF];
$overwrite = !$propertyValues[$i][self::IS_REF];
}
}

return true;
Expand Down
0