8000 [Form] Rename CollectionType options `type` and `options` by wouterj · Pull Request #13820 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Form] Rename CollectionType options type and options #13820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 74 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
a4e3e07
feature #14443 [VarDumper] Allow preserving a subset of cut arrays (n…
nicolas-grekas Apr 23, 2015
f5a0ac2
Merge branch '2.7' into 2.8
nicolas-grekas Apr 24, 2015
e6d05b7
Merge branch '2.7' into 2.8
nicolas-grekas Apr 24, 2015
dc89425
Merge branch '2.7' into 2.8
nicolas-grekas Apr 24, 2015
b09df56
Merge branch '2.7' into 2.8
nicolas-grekas Apr 24, 2015
b941bd3
Changed output for translation:debug command
Apr 26, 2015
7e29d2c
feature #14473 [DX] Minor improvement for the translation:debug outpu…
aitboudad Apr 26, 2015
0e7fe79
added the --all option to the debug:translation command
sgehrig Apr 11, 2015
1973960
feature #14320 [Translation] added an --all option to the debug:trans…
aitboudad Apr 29, 2015
952929c
[FrameworkBundle][EventDispatcher] Add priorities to the debug:event-…
Seldaek May 5, 2015
2869a32
[Translator] deprecate getMessages in favor of getCatalogue.
aitboudad May 4, 2015
55b3525
feature #14546 [Translator] deprecate getMessages in favor of getCata…
aitboudad May 6, 2015
da0194b
feature #14563 [FrameworkBundle][EventDispatcher] Add priorities to t…
fabpot May 6, 2015
128140e
fixed CS
fabpot May 6, 2015
bba0a25
[FrameworkBundle][DX] Add option to specify additional translation lo…
Seldaek May 5, 2015
88b7e7c
feature #14561 [FrameworkBundle][DX] Add option to specify additional…
aitboudad May 6, 2015
bb8b076
Merge branch '2.7' into 2.8
nicolas-grekas May 12, 2015
5133bf2
Merge branch '2.7' into 2.8
nicolas-grekas May 12, 2015
aef24cb
Merge branch '2.7' into 2.8
nicolas-grekas May 13, 2015
2119bf3
Merge branch '2.7' into 2.8
nicolas-grekas May 15, 2015
4b71fe0
Merge branch '2.7' into 2.8
fabpot May 15, 2015
5fdc650
[WebProfilerBundle] Improved page for logs
hason Jan 7, 2015
65d4ae0
feature #13324 [WebProfilerBundle] Improved page for logs (hason)
fabpot May 17, 2015
53330e1
[Form] deprecate read_only option
Tobion Apr 18, 2015
791e583
feature #14403 [Form] deprecate read_only option (Tobion)
fabpot May 20, 2015
29ec5ca
[Translation] add options 'as_tree', 'inline' to YamlFileDumper to du…
gepo Apr 21, 2015
a57ce90
feature #14630 [Translator] Dump translation constants as tree instea…
aitboudad May 20, 2015
3fd7cea
[Security] Add setVoters() on AccessDecisionManager
nicolas-grekas May 23, 2015
0573f28
Support for array denormalization.
derrabus Apr 13, 2015
2983ecb
feature #14756 [Serializer] Support for array denormalization (derrabus)
dunglas May 27, 2015
78cf382
feature #14733 [Security] Add setVoters() on AccessDecisionManager (n…
fabpot Jun 1, 2015
73f0ee2
[DI][Routing] recursive directory loading
lavoiesl Jun 10, 2014
60b1c5b
Added CHANGELOG entries, cleanups
nicolas-grekas May 20, 2015
5593bdd
Merge branch '2.7' into 2.8
fabpot Jun 4, 2015
d04cc5e
feature #14700 [DependencyInjection] [Routing] [Config] Recursive dir…
fabpot Jun 5, 2015
99ec717
Merge branch '2.7' into 2.8
fabpot Jun 5, 2015
3cbff05
[TwigBundle] Reconfigure twig paths when they are updated
chbruyand May 29, 2015
4133aad
feature #14781 [TwigBundle] Reconfigure twig paths when they are upda…
fabpot Jun 5, 2015
9004e29
Removed route name from the debugbar.
jbgomond Jun 7, 2015
1baf05a
added missing "
OskarStark Jun 8, 2015
90f771c
minor #14909 added missing " (OskarStark)
fabpot Jun 8, 2015
5b67bbd
[toolbar] Merged colored icons in toolbar
jbgomond Jun 7, 2015
567af65
feature #14904 [toolbar] Merged colored icons in toolbar (MJBGO)
fabpot Jun 8, 2015
0315e5d
feature #14903 [profiler][request toolbar] Removed route name from th…
fabpot Jun 8, 2015
f38296b
Merge branch '2.7' into 2.8
fabpot Jun 9, 2015
2ad3b0d
[HttpFoundation] Postpone setting the date header on a Response
jakzal Jun 8, 2015
a44ceb3
feature #14912 [HttpFoundation] Postpone setting the date header on a…
Tobion Jun 9, 2015
ae470cd
Merge branch '2.7' into 2.8
fabpot Jun 11, 2015
692deff
fix Merge branch '2.7' into 2.8 JsonFileLoader
gimler Jun 11, 2015
5f36605
minor #14954 fix Merge branch '2.7' into 2.8 JsonFileLoader (gimler)
fabpot Jun 11, 2015
65f9291
[Profiler][Translation] added filter.
aitboudad Jun 15, 2015
15ff865
feature #14993 [Profiler][Translation] added filter. (aitboudad)
fabpot Jun 15, 2015
b52e197
[Form] Added the 'range' FormType
jaytaph Sep 27, 2014
09fabfe
feature #12067 [Form] Added the 'range' FormType (jaytaph)
webmozart Jun 17, 2015
80b0a80
[Form] Add "prototype_data" option to collection type
kgilden Oct 24, 2014
54bd6f7
feature #12314 [Form] Add "prototype_data" option to collection type …
webmozart Jun 17, 2015
6c554c6
[Form] Deprecated "cascade_validation"
webmozart Oct 16, 2014
04ae391
feature #15019 [Form] Deprecated "cascade_validation" (webmozart)
fabpot Jun 17, 2015
74d794b
[Form] [EventListener] fixed sending non array data on submit to Resi…
BruceWouaigne Mar 5, 2015
63c8ce9
bug #13851 [Form] [EventListener] fixed sending non array data on pre…
webmozart Jun 18, 2015
e2a051d
Rename CollectionType options for entries
wouterj Mar 1, 2015
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch '2.7' into 2.8
* 2.7: (70 commits)
  [travis] Use container-based infrastructure
  [HttpKernel] use ConfigCache::getPath() method when it exists
  [PropertyAccess] Fix setting public property on a class having a magic getter
  [Routing] Display file which contain deprecated option
  ContainerInterface: unused exception dropped
  bumped Symfony version to 2.6.8
  updated VERSION for 2.6.7
  updated CHANGELOG for 2.6.7
  bumped Symfony version to 2.3.29
  updated VERSION for 2.3.28
  update CONTRIBUTORS for 2.3.28
  updated CHANGELOG for 2.3.28
  [Debug] Fixed ClassNotFoundFatalErrorHandlerTest
  [SecurityBundle] use access decision constants in config
  [SecurityBundle] use session auth constants in config
  PhpDoc fix in AbstractRememberMeServices
  [Filesystem] Simplified an if statement
  [SecurityBundle] Use Enum Nodes Instead Of Scalar
  [Debug 2.3] Fix test for PHP7
  [HttpKernel] Check if "symfony/proxy-manager-bridge" package is installed
  ...

Conflicts:
	src/Symfony/Bundle/DebugBundle/composer.json
	src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
	src/Symfony/Component/Form/README.md
	src/Symfony/Component/Intl/README.md
	src/Symfony/Component/Security/README.md
	src/Symfony/Component/Translation/Loader/CsvFileLoader.php
	src/Symfony/Component/Translation/Loader/IniFileLoader.php
	src/Symfony/Component/Translation/Loader/MoFileLoader.php
	src/Symfony/Component/Translation/Loader/PhpFileLoader.php
	src/Symfony/Component/Translation/Loader/PoFileLoader.php
	src/Symfony/Component/Translation/Loader/YamlFileLoader.php
	src/Symfony/Component/Translation/README.md
	src/Symfony/Component/Translation/Translator.php
	src/Symfony/Component/Validator/README.md
  • Loading branch information
nicolas-grekas committed May 12, 2015
commit bb8b0769cbaa6f0eb75787ca293b3becaa1d5af8
3 changes: 2 additions & 1 deletion src/Symfony/Bundle/DebugBundle/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"require-dev": {
"symfony/phpunit-bridge": "~2.7|~3.0.0",
"symfony/config": "~2.3|~3.0.0",
"symfony/dependency-injection": "~2.3|~3.0.0"
"symfony/dependency-injection": "~2.3|~3.0.0",
"symfony/web-profiler-bundle": "~2.3|~3.0.0"
},
"suggest": {
"symfony/config": "For service container configuration",
Expand Down
10000 13 changes: 3 additions & 10 deletions src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
$address = $input->getArgument('address');

if (false === strpos($address, ':')) {
$output->writeln('The address has to be of the form <comment>bind-address:port</comment>.');

return 1;
$address = $address.':'.$input->getOption('port');
}

if ($this->isOtherServerProcessRunning($address)) {
Expand All @@ -115,15 +113,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
$output->writeln('<error>Running PHP built-in server in production environment is NOT recommended!</error>');
}

$address = $input->getArgument('address');
if (false === strpos($address, ':')) {
$address = $address.':'.$input->getOption('port');
}

$output->writeln(sprintf("Server running on <info>http://%s</info>\n", $address));
$output->writeln('Quit the server with CONTROL-C.');

if (null === $builder = $this->createPhpProcessBuilder($input, $output, $env, $address)) {
if (null === $builder = $this->createPhpProcessBuilder($output, $address, $input->getOption('router'), $env)) {
return 1;
}

Expand All @@ -150,7 +143,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
return $process->getExitCode();
}

private function createPhpProcessBuilder(InputInterface $input, OutputInterface $output, $env, $address)
private function createPhpProcessBuilder(OutputInterface $output, $address, $router, $env)
{
$router = $router ?: $this
->getContainer()
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Form/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ https://github.com/fabpot/Silex/blob/master/src/Silex/Provider/FormServiceProvid

Documentation:

http://symfony.com/doc/2.8/book/forms.html
https://symfony.com/doc/2.8/book/forms.html

Resources
---------
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Intl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ You can run the unit tests with the following command:
$ phpunit

[0]: http://www.php.net/manual/en/intl.setup.php
[1]: http://symfony.com/doc/2.8/components/intl.html
[1]: https://symfony.com/doc/2.8/components/intl.html
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Resources

Documentation:

http://symfony.com/doc/2.8/book/security.html
https://symfony.com/doc/2.8/book/security.html

Tests
-----
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/Translation/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ CHANGELOG

2.8.0
-----
* deprecated Translator::getMessages(), rely on the TranslatorBagInterface::getCatalogue() method instead.

* deprecated Translator::getMessages(), use TranslatorBagInterface::getCatalogue() instead.

2.7.0
-----
Expand Down
5 changes: 4 additions & 1 deletion src/Symfony/Component/Translation/Loader/FileLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ public function load($resource, $locale, $domain = 'messages')
}

$catalogue = parent::load($messages, $locale, $domain);
$catalogue->addResource(new FileResource($resource));

if (class_exists('Symfony\Component\Config\Resource\FileResource')) {
$catalogue->addResource(new FileResource($resource));
}

return $catalogue;
}
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Translation/Loader/YamlFileLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ class YamlFileLoader extends FileLoader
protected function loadResource($resource)
{
if (null === $this->yamlParser) {
if (!class_exists('Symfony\Component\Yaml\Parser')) {
throw new \LogicException('Loading translations from the YAML format requires the Symfony Yaml component.');
}

$this->yamlParser = new YamlParser();
}

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Translation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ https://github.com/fabpot/Silex/blob/master/src/Silex/Provider/TranslationServic

Documentation:

http://symfony.com/doc/2.8/book/translation.html
https://symfony.com/doc/2.8/book/translation.html

You can run the unit tests with the following command:

Expand Down
8 changes: 5 additions & 3 deletions src/Symfony/Component/Translation/Translator.php
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,15 @@ protected function getLoaders()
* @param string|null $locale Locale of translations, by default is current locale
*
* @return array[array] indexed by catalog
*
* @deprecated since version 2.8, to be removed in 3.0. Use TranslatorBagInterface::getCatalogue() method instead.
*/
public function getMessages($locale = null)
{
trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0. Rely on the TranslatorBagInterface::getCatalogue() method instead', E_USER_DEPRECATED);
trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0. Use TranslatorBagInterface::getCatalogue() method instead.', E_USER_DEPRECATED);

$catalogues = array();
$catalogues[] = $catalogue = $this->getCatalogue($locale);
$catalogue = $this->getCatalogue($locale);
$messages = $catalogue->all();
while ($catalogue = $catalogue->getFallbackCatalogue()) {
$messages = array_replace_recursive($catalogue->all(), $messages);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ https://github.com/fabpot/Silex/blob/master/src/Silex/Provider/ValidatorServiceP

Documentation:

http://symfony.com/doc/2.8/book/validation.html
https://symfony.com/doc/2.8/book/validation.html

JSR-303 Specification:

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0