8000 [3.0][Console] Added type hint by francisbesset · Pull Request #13756 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[3.0][Console] Added type hint #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[3.0][Console] Added type hint #13756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Console] Added type hint
  • Loading branch informa 8000 tion
@francisbesset
francisbesset committed Feb 23, 2015
commit 542e7ff58d01051bb6a452368c0ab8863008d21a
4 changes: 4 additions & 0 deletions UPGRADE-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ UPGRADE FROM 2.x to 3.0
$table->render();
```

* Parameters of `renderException()` method of the
`Symfony\Component\Console\Application` are type hinted.
You must add the type hint to your implementations.

### DependencyInjection

* The methods `Definition::setFactoryClass()`,
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ public function asXml($namespace = null, $asDom = false)
* @param \Exception $e An exception instance
* @param OutputInterface $output An OutputInterface instance
*/
public function renderException($e, $output)
public function renderException(\Exception $e, OutputInterface $output)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BC break, maybe this should be done for the master (3.0) instead?

{
do {
$title = sprintf(' [%s] ', get_class($e));
Expand Down
0