[DomCrawler] [3.0] Abstract URI logic and crawl images #13650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the URI parsing logic is externalized in the AbstractUriElement class, implementing the UriElementInterface interface. The AbstractUriElement class have two abstract methods: * setNode: validate the DOMElement node according to the concrete class rules, and set $this->node. * getRawUri: get the raw URI from $this->node. The Link classs now extends AbstractUriElement. This refactor is desirable for #12429.
A new Image class is added, extending AbstractUriElement, to leverage URI methods for the HTML img src attribute. Two methods are added to the Crawler class, image and images, that are the equivalent of link and links for images.
* `Form` now extends `AbstractUriElement` instead of `Link`. * The `node` and `method` properties of `AbstractUriElement` are now private (they already have public getters). * Since `node` is private, `setNode` in child classes can't set the `node` property directly, thus `setNode` have been renamed to `findNode` and now returns the node instead of setting the property.
|
This one should be rebased once #13649 (or the new one on master) is merged |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 10, 2016
This PR was merged into the master branch. Discussion ---------- [DomCrawler] Document images crawler | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#13649, symfony/symfony#13650) | Applies to | 3.0.0 | Fixed tickets | symfony/symfony#12429 Commits ------- 355a83f [DomCrawler] Document images crawler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3.0-ready version of #13649 (I cherry-picked the two first commits and added "Cleanup AbstractUriElement" which contains the actual changes for 3.0 according to the discussion in #13620).