[Form][DoctrineBridge] Optimize EntityType by only loading choices for values restricted by values #13606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y that EntityLoader customization does (if you provide a query_builder).
|
Recently I had to manage this behavior through form options since I have a lot of choices and performance was seriously degraded with the amount of results. |
|
Does it make sense to merge this into 2.3? |
|
@fabpot Yes. =) Doctrine 2.3 addressed some issues with I'd say it makes sense to merge in all branches if they're maintained. |
|
Thank you @guilhermeblanco. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2015
… choices for values restricted by values (guilhermeblanco) This PR was merged into the 2.7 branch. Discussion ---------- [Form][DoctrineBridge] Optimize EntityType by only loading choices for values restricted by values | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Optimize EntityType by only loading choices for values in the same way that EntityLoader customization does (if you provide a query_builder). Commits ------- 2185883 Optimize EntityType by only loading choices for values in the same way that EntityLoader customization does (if you provide a query_builder).
|
@fabpot Why this was not merged into Symfony 2.6? |
|
@guilhermeblanco Sorry about that, I made a mistake when merging. I'm going to merge it manually into 2.3. |
|
This commit introduces an issue with mongodb, see #13961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize EntityType by only loading choices for values in the same way that EntityLoader customization does (if you provide a query_builder).