8000 [2.3] [Validator] spanish translation for invalid charset message by phansys · Pull Request #13569 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[2.3] [Validator] spanish translation for invalid charset message #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

phansys
Copy link
Contributor
@phansys phansys commented Feb 1, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

ref. #13528

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

ref. symfony#13528
@@ -278,6 +278,10 @@
<source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
<target>Este valor no debería ser idéntico a {{ compared_value_type }} {{ compared_value }}.</target>
</trans-unit>
<trans-unit id="73">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id is 80 now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thank you @nicolas-grekas.

@javiereguiluz
Copy link
Member

@phansys I'm not sure if this translation is 100% accurate. It now says: "this value doesn't match 'UTF-8'" and it should say "the charset of this value doesn't match UTF8" or "this value doesn't use the UTF8 charset".

@phansys
Copy link
Contributor Author
phansys commented Feb 1, 2015

@javiereguiluz, it's updated now based on your comments.

@javiereguiluz
Copy link
Member

@phansys thanks!

👍 the translation is now accurate.

@fabpot
Copy link
Member
fabpot commented Feb 2, 2015

Thank you @phansys.

fabpot added a commit that referenced this pull request Feb 2, 2015
…t message (phansys)

This PR was squashed before being merged into the 2.3 branch (closes #13569).

Discussion
----------

[2.3] [Validator] spanish translation for invalid charset message

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

ref. #13528

Commits
-------

40ace96 [2.3] [Validator] spanish translation for invalid charset message
@fabpot fabpot closed this Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0