10000 removed deprecation notice for internal constant by fabpot · Pull Request #13462 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

removed deprecation notice for internal constant #13462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2015

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 20, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This notice is being raised when using the legacy validator, but it shouldn't. Moreover, as this is purely an internal constant, there is no point in raising a notice anyway.

@fabpot fabpot force-pushed the deprecation-notice-removal branch from bdf0518 to 19be8b0 Compare January 20, 2015 00:48
@fabpot fabpot merged commit 19be8b0 into symfony:2.7 Jan 20, 2015
fabpot added a commit that referenced this pull request Jan 20, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

removed deprecation notice for internal constant

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This notice is being raised when using the legacy validator, but it shouldn't. Moreover, as this is purely an internal constant, there is no point in raising a notice anyway.

Commits
-------

19be8b0 removed deprecation notice for internal constant
@fabpot fabpot deleted the deprecation-notice-removal branch February 12, 2015 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0