Fix usage of app.security #13460
Merged
Fix usage of app.security #13460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dddc7bc to
09ed9b5
Compare
fabpot
added a commit
that referenced
this pull request
Jan 20, 2015
This PR was merged into the 2.7 branch. Discussion ---------- Fix usage of app.security | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Reverts the previous attempt to remove notices when using the `app.security` variable in Twig because it did not work (it prevents using `app.security` altogether). So, instead, we inject the container and only get the security service (and thus triggering the deprecation notice) when the user is using `app.security`. Commits ------- 09ed9b5 removed deprecated notices when using the security service 1067cc5 Revert "minor #13434 fixed some deprecated notices (fabpot)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the previous attempt to remove notices when using the
app.securityvariable in Twig because it did not work (it prevents usingapp.securityaltogether).So, instead, we inject the container and only get the security service (and thus triggering the deprecation notice) when the user is using
app.security.