[Process] Make test AbstractProcessTest::testStartAfterATimeout useful again #13446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meout()
Without this change any \Exception is caught in this test, especially even
the one thrown with:
$this->fail('A RuntimeException should have been raised.');
Thus catching any exception in this tests makes it pretty useless.
48378be to
6b45999
Compare
…meout()
Previously to this commit the command executed in the tests actually was:
# php -r "$n = 1000; while ($n--) {echo ''; usleep(1000); }"
This does not (as intended) wait ~1s, but produces the following error:
PHP Parse error: syntax error, unexpected '=' in Command line code on line 1
6b45999 to
675bc34
Compare
|
Thank you @ymc-dabe. |
fabpot
added a commit
that referenced
this pull request
Feb 4, 2015
…Timeout useful again (ymc-dabe) This PR was squashed before being merged into the 2.3 branch (closes #13446). Discussion ---------- [Process] Make test AbstractProcessTest::testStartAfterATimeout useful again | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The test AbstractProcessTest::testStartAfterATimeout() is pretty useless, due to two reasons: 1. Any exception is caught This means even the exception thrown with <code>$this->fail('A RuntimeException should have been raised.');</code> is caught, making the test pretty useless. 2. Invalid PHP code gets executed The command that is executed in the tests actually is: <code># php -r "$n = 1000; while ($n--) {echo ''; usleep(1000); }"</code> . This does not wait ~1s, but produces the following error: <code>PHP Parse error: syntax error, unexpected '=' in Command line code on line 1</code> Commits ------- 1be266f [Process] Make test AbstractProcessTest::testStartAfterATimeout useful again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test AbstractProcessTest::testStartAfterATimeout() is pretty useless, due to two reasons:
This means even the exception thrown with
$this->fail('A RuntimeException should have been raised.');is caught, making the test pretty useless.
The command that is executed in the tests actually is:
# php -r "$n = 1000; while ($n--) {echo ''; usleep(1000); }".
This does not wait ~1s, but produces the following error:
PHP Parse error: syntax error, unexpected '=' in Command line code on line 1